pkg/cli: disable termios `IXON` flag, which prevents `C-q` and `C-s` keymaps.

elves / elvish

Powerful scripting language & versatile interactive shell

https://elv.sh/

BSD 2-Clause "Simplified" License

5.65k stars 299 forks source link

pkg/cli: disable termios `IXON` flag, which prevents `C-q` and `C-s` keymaps. #1801

Closed plaukiu closed 5 months ago

plaukiu commented 5 months ago

IXON and the messages that it enables have no use in current terminals. According to wiki, it's been used to temporarily halt the process whenever slow hardware devices couldn't catch up with outputs. This is not a problem nowadays, so it should be safe to keep this flag disabled.

plaukiu commented 5 months ago

(I'm sorry if I was too quick with this PR, I get too excited sometimes haha)

xiaq commented 5 months ago

I've merged this to a separate branch and noted down some issues to address before merging into master. I'll probably be able to do the fixup myself on Monday, but feel free to open a further PR before that if you like.

xiaq commented 1 month ago

Sorry I forgot about integrating this for a while 🥲. I applied my followup changes and it's been merged in https://github.com/elves/elvish/commit/9bfc49aa9c1de210b245481888a13784052045bb!