xiaq
commented
1 month ago Hi, sorry for not getting to this. I've wanted to try Nix for a while, so I've been sitting on this PR thinking that I'd get to it once I learned enough Nix to understand what's going on. But it's taken a bit too long, so I thought I should at least post a response.
I try to ensure that I can maintain the entire Elvish codebase, so in general I don't accept code that I don't fully understand unless there's a very compelling reason to do so. Can you tell me:
-
I see there's already an Elvish package in nixpkgs. What's the relationship between it and this PR?
-
Can the files in the PR reasonably live in a separate repo?
elvish is already packaged in nix, but adding flake file in the project can provide reproducible build, develop environment. And helpful for someone who wants to package any version of elvish they want (nightly build or even fork..).