Feature/console output refinement

elvetemedve / behat-screenshot

This is an extension for Behat which provides debugging functionality by taking a screenshot of failed tests.

MIT License

92 stars 17 forks source link

Feature/console output refinement #10

Closed elvetemedve closed 8 years ago

elvetemedve commented 8 years ago

This PR delivers the following improvements:

Symfony console component is not required to be directly installed by Composer (replaced by "cli.output" service from Behat)
Output is coloured if console supports ANSI characters (see --color and --no-color switches)
Indentation is added to every line to make the message look a bit better

elvetemedve commented 8 years ago

Tests for PHP 5.4 are failing, because Behat pulls in an symfony/console ~2.1, which does not have the isQuiet() method. :-/ PHP 5.4 itself is not supported since 2015 September, maybe it's time to drop support here too.

elvetemedve commented 8 years ago

isQuiet() call is removed, code has been refactored.

tkotosz commented 8 years ago

looks good to me, nice one @elvetemedve :+1: