search

elvetemedve / gnome-shell-extension-system-monitor

Gnome Shell extension for displaying resource usage
GNU General Public License v3.0
87 stars 14 forks source link

Gnome 3.32 support #56

Closed alexandru-calinoiu closed 5 years ago

alexandru-calinoiu commented 5 years ago

Any chance to support the latest gnome version?

Looking at the logs it seems the error is:

xtension "System_Monitor@bghome.gmail.com" had error: TypeError: this._construct is not a function
lfelipe1501 commented 5 years ago

yes please support Gnome 3.32

elvetemedve commented 5 years ago

I will try to look into that this week.

mon0theist commented 5 years ago

Can confirm, needs update for GNOME 3.32

mon0theist commented 5 years ago

Not sure if this helps, saw this on another extension that was broken by the 3.32 update:

"GNOME Shell 3.32 removed Lang.class() and we should be using ES6 classes instead. See https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/361"

elvetemedve commented 5 years ago

@mon0theist Thanks, that helps. I already eliminated depending on the Lang class in the code. But there are other changes that break the functionality. So it needs more work. :(

bararchy commented 5 years ago

@elvetemedve Not sure if needed but I'm also following and need an update :)

dino99 commented 5 years ago

job already done, and works as expected: https://github.com/paradoxxxzero/gnome-shell-system-monitor-applet/pull/510

mrksngl commented 5 years ago

@dino99 not sure if I mess something up here, but I think this is another monitor applet. This repositoriy is linked from https://extensions.gnome.org/extension/1064/system-monitor/ but the repo you're referring at looks more like https://extensions.gnome.org/extension/120/system-monitor/

elvetemedve commented 5 years ago

This is now fixed in Version 15. It will be released at extensions.gnome.org soon.