search

elvetemedve / gnome-shell-extension-system-monitor

Gnome Shell extension for displaying resource usage
GNU General Public License v3.0
87 stars 14 forks source link

Update extension for Gnome Shell 43 support #87

Closed tukanos closed 1 year ago

tukanos commented 1 year ago

Updating extension for Gnome Shell 43. All credits go to farlydetrias2022

feimosi commented 1 year ago

@tukanos did you test if it's enough to make it work on v43? @elvetemedve any chance to merge it? :)

tukanos commented 1 year ago

@feimosi That is good question. How do you properly test an extension? It does not have any tests with it.

I have made the modification the PR is proposing. The extension works for me the same way as it worked before. This does not, of course, mean that it will work for everyone else.

feimosi commented 1 year ago

Yes, by "test" I just meant if it runs on your machine. I assume that if it works for you on Gnome 43 then there's a 99% chance it's going to work on Gnome on other distros.

elvetemedve commented 1 year ago

Sorry for the late reply. I'm going to check this out now.

There are no automated tests for this, because that should run the extension under various version of the Gnome Shell and this is not supported by Gnome out of the box AFAIK. Builder is said to be supporting such, but it was under heavy development at the time this extension was built. So you test it by run and watch the Systemd log of the Gnome desktop session.

elvetemedve commented 1 year ago

It seems to work well with version 43.

feimosi commented 1 year ago

Thanks @elvetemedve!