elvissteinjr / DesktopPlus

Advanced desktop access for OpenVR
GNU General Public License v3.0
467 stars 29 forks source link

Keyboard position does not follow overlay position #31

Open matejdro opened 2 years ago

matejdro commented 2 years ago

With NewUI Preview 3, Keyboard position seems to be stuck in the same place.

I can reproduce with the following steps:

  1. Create a new overlay that is positioned to the dashboard
  2. Open keyboard on that overlay
  3. Close keyboard
  4. Spun around 180 degrees
  5. Reopen dashboard to reposition the overlay
  6. Open keyboard
  7. Keyboard will be stuck where it was at step 2
elvissteinjr commented 2 years ago

I took a look at it seems to behave correctly on my end. It's not supposed to move when pinned to the play-space and re-positions if it's not and dashboard is open (but also auto-closes if dashboard closed).

Now what I do have notice is that this design is probably not always ideal. My current thoughts about keyboard overlay positioning are the following:

Another potential item on that list would be to keep visibility state for dashboard so window overlays automatically appear again as well when opening the dashboard.

I might be missing some crucial scenario here though, so I'd appreciate it if you have any input before I just rush to implement it like that.

matejdro commented 2 years ago

Here is the recording of my issue:

https://user-images.githubusercontent.com/507922/143488861-acd5f48b-dbba-480e-8ac3-0efb98933aed.mp4

elvissteinjr commented 2 years ago

Yeah, since the keyboard is pinned in the video it's "working as intended" (has to be pinned, so that happens automatically). The video shows well how wrong these intentions were (what I posted last time were thoughts for changes, not current behavior). Currently, unpinned in Desktop+ dashboard tab follows that, everything else is following play-space, so it won't move on its own beyond initial placement.

What you can do until this is sorted out is to long hold the Show Keyboard button to reset the position. Sorry about that.