HP Reverb controllers reconnecting after sleep crashes SteamVR when Desktop+ is running

elvissteinjr / DesktopPlus

Advanced desktop access for OpenVR

GNU General Public License v3.0

454 stars 29 forks source link

HP Reverb controllers reconnecting after sleep crashes SteamVR when Desktop+ is running #38

Open Taomyn opened 2 years ago

Taomyn commented 2 years ago

When my HP Reverb G2 controllers switch off after sleeping and I then power them back on, SteamVR crashes when Desktop+ is also running. If I disable Desktop+ this does not happen. Oddly, if I start SteamVR without the controllers powered on and then power them on, it does not crash but does if they subsequently sleep then power back on.

I have tried both v2.61 and NewUI Preview 4, both do it and I have nothing else running through Steam when I test.

I'm running on Windows 11, WMR is up-to-date, running Steam beta (16/12), SteamVR beta and WMR for SteamVR beta.

elvissteinjr commented 2 years ago

Mhm, I don't have any WMR hardware or am running Windows 11 anywhere right now. I know nothing bad happens with Index controllers at least and I don't think I'm doing anything that should provoke a SteamVR crash, but I'd need your help checking here.

There are two things that do happen in Desktop+ right away when a controller has connected to or disconnected from SteamVR:

The Performance Montior's SteamVR Tracker battery list is refreshed in case the related device was a tracker
The Desktop+ SteamVR input action bindings are queried to see if they are currently bound to any connected device

The first one happens in DesktopPlusUI.exe, so you could check if the crash still happens if you only have DesktopPlus.exe running. The second one has been in there for ages, but if you go all the way back to v2.0.1 you'd have a build without this behavior to check against.

At least that's the best I can come up with right now. Hopefully we can narrow this down.

Taomyn commented 2 years ago

@elvissteinjr thanks for the advice, unfortunately I started to have other system issues with Windows 11 that I don't think are the fault of anything SteamVR related or your app so I'm in the slow process of rebuilding my machine from a clean install then see how it goes. Personally I blame Oculus and their garbage as everything was fine until I uninstalled it all after getting the Reverb set up.

Taomyn commented 2 years ago

Hey @elvissteinjr I thought you'd like an update. Seems my troubles got no better after the clean install of Win11, so the cause was not Oculus software as I was thinking. I could also force a crash by running a Geekbench 5 CPU benchmark so I ran the Windows Memory Diagnostic and it reported several problems with my RAM. It was almost at the end of the test when the errors showed - perhaps the recent changes forced Windows to use areas of RAM it wasn't using before and so began crashing, or simply that it started to degrade.

Anyway I was able to downclock the RAM speed in the BIOS and got back the stability, in the meantime I have some new memory on order that I hope to pickup today.

So far Desktop+ (newui) is working although I've not really had time this week to play much VR.