search

elwayman02 / ember-interactivity

Latency Tracking for Ember Applications
http://jhawk.co/interactivity-demo
MIT License
33 stars 5 forks source link

Ember Octane #103

Open lvegerano opened 5 years ago

lvegerano commented 5 years ago

Are there any plans of supporting Octane/glimmer components?

elwayman02 commented 5 years ago

@lvegerano I haven't made specific plans for this, but that's a great idea! If anyone wants to drop some thoughts in here about how to do that (likely a decorator?), we can use this issue as a starting point.

lvegerano commented 5 years ago

A decorator would work the only issue I see so far is the willInsertElement method. Glimmer components don't have this hook.

elwayman02 commented 5 years ago

SPENCER SAYS THIS SHOULD BE A MODIFIER :tent:

lvegerano commented 5 years ago

🤷‍♂ Still run into some of the same issues. One particular would be tracking component counts. Glimmer components don't have a unique id (not that I was able to find) they would have to be tagged by the lib somehow.

NullVoxPopuli commented 4 years ago

modifier or decorator? o.o maybe both? let the user choose? :D

elwayman02 commented 4 years ago

I wonder if we could use PerformanceObserver...