search

elwayman02 / ember-is-visible

Visibility Detection for Ember Apps
http://jhawk.co/ember-visible-demo
MIT License
2 stars 1 forks source link

Add old browsers compatibility #19

Closed shokmaster closed 5 years ago

shokmaster commented 5 years ago

This commit adds compatibility with old browsers, and remove all bindings on service teardown.

elwayman02 commented 5 years ago

Looks like there are some errors here related to travis running tests in Node 4. Since I believe Ember-CLI has finally dropped support for Node 4 in the latest versions, I'll get that updated and then we can rebase this PR to get the build passing. Thanks for contributing this, it looks great!

shokmaster commented 5 years ago

I've pushed the new config for Travis with Node 6, and we've it running ok :)

elwayman02 commented 5 years ago

Awesome! It may take me a few days to have time to release it, but I'm happy to merge this to master now.