search

elwayman02 / ember-scroll-modifiers

Scroll-based Modifiers for Ember.js Applications
https://ember-scroll-modifiers.jhawk.co/
MIT License
21 stars 11 forks source link

Add TypeScript Support #1103

Open runspired opened 3 weeks ago

runspired commented 3 weeks ago

any chance of getting some types, even if just bare bones d.ts? :D

elwayman02 commented 2 weeks ago

This is something I want to do, but I can't give a timeline on it. Might be months before I'm able to get to it. Would happily review PRs integrating TypeScript dependencies or adding some types. Iterative progress is totally ok, and any PRs that get us closer mean it's more likely I can devote small amounts of time to it myself.

cloke commented 1 week ago

Would the goal be to convert to typescript or to just export definitions. I have a definitions file I will PR once the v2 add-on stuff is done. Looks like a full conversion to TS wouldn't be a huge lift and can look at that as well.

elwayman02 commented 1 week ago

I think long-term goal is full conversion, but any steps that get us closer are a good thing!

cloke commented 1 week ago

Full conversion doesn't look to hard. Once the v2 add-on is done I'll just convert to ts fully. Just don't want lots of moving parts at once.