elwayman02 / ember-sinon-qunit

Sinon sandbox test integration for QUnit
MIT License
58 stars 30 forks source link

Can we import QUnit directly? #530

Closed elwayman02 closed 1 year ago

elwayman02 commented 2 years ago

Currently we reference self.QUnit, but I honestly don't remember if that was necessary or if I just didn't think about importing it back then. 😅

https://github.com/elwayman02/ember-sinon-qunit/blob/master/addon-test-support/index.js#L11

An explicit import seems much better, if it works.

elwayman02 commented 1 year ago

Fixed by #755