elwerene / libreoffice-convert

MIT License
241 stars 94 forks source link

Added customBinary code #25

Closed mimedo closed 3 years ago

mimedo commented 4 years ago

Extraced default paths as constants and added condition to check if customBinaryPaths are defined and if it's an array.

If parameter undefined, default path's are taken for further processing

elwerene commented 4 years ago

I think it would be better to provide a second method which

mimedo commented 4 years ago

I hope this solution works. I come more from a backend java world. Javascript is still "weird" for me :)

elwerene commented 4 years ago

Please make a function where you can set the custom binary path or provide a function like yours, but without setting a global variable which could lead to problems like calling a wrong libreoffice binary if using multiple different binaries at the same time.

Method 1

Method 2