search

elwerene / libreoffice-convert

MIT License
241 stars 94 forks source link

convert installDir to posix format #47

Closed ilkohoffmann closed 3 years ago

ilkohoffmann commented 3 years ago

this pull request fixes #32

elwerene commented 3 years ago

@ilkohoffmann Doesn't this break on windows? In the documentation it says, the path.sep is \ in windows which is correct as far as I know. You replace it with path.posix.sep which should always be / - I can't test it on Windows as I don't have access to a installation. Or did I miss a change in Windows path behavior and it now accepts /?

ilkohoffmann commented 3 years ago

@ilkohoffmann Doesn't this break on windows? In the documentation it says, the path.sep is \ in windows which is correct as far as I know. You replace it with path.posix.sep which should always be / - I can't test it on Windows as I don't have access to a installation. Or did I miss a change in Windows path behavior and it now accepts /?

See comment here https://github.com/elwerene/libreoffice-convert/issues/32#issuecomment-725263795