search

elwerene / libreoffice-convert

MIT License
241 stars 94 forks source link

specify custom path for soffice binaries #83

Closed snigdha920 closed 2 years ago

snigdha920 commented 2 years ago

This PR aims to resolve https://github.com/elwerene/libreoffice-convert/issues/49, https://github.com/elwerene/libreoffice-convert/issues/60.

Now, users can add a custom path to the soffice binary. This is particularly useful while using this package in deployments, eg. Heroku deployment.

I have extended the options object to add sofficeBinaryPaths as suggested here. The users can now specify the path to soffice binary depending on where the soffice binaries are installed.

snigdha920 commented 2 years ago

@elwerene looking forward to your review, please let me know about any changes / improvements.

elwerene commented 2 years ago

why did you make it an array and not just one path? I can't think of a situation where you would need to supply more than one binary path.

snigdha920 commented 2 years ago

why did you make it an array and not just one path? I can't think of a situation where you would need to supply more than one binary path.

In case someone had a different location in a local installation (and they don't wish to ln) + the path for the installation on a deployment. I'll remove it if you think this reason is not good enough. :)

elwerene commented 2 years ago

you convinced me :)