search

elwerene / libreoffice-convert

MIT License
241 stars 94 forks source link

Everybody's node app is crashing. #84

Closed himanshu-grover-vm closed 1 year ago

himanshu-grover-vm commented 2 years ago

Hello,

Error while node app building with node v10: UnhandledPromiseRejectionWarning: /home/ubuntu/app/node_modules/libreoffice-convert/index.js:17 let paths = (options || {}).sofficeBinaryPaths ?? [];

Latest changes in the repository: https://github.com/elwerene/libreoffice-convert/commit/e0eae70d85c2f605b93efa0ab132503d1d2316a0#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346R17

memlucky71 commented 2 years ago

I have this problem too

paskon-intarasak commented 2 years ago

Hello,

Error while node app building with node v10: UnhandledPromiseRejectionWarning: /home/ubuntu/app/node_modules/libreoffice-convert/index.js:17 let paths = (options || {}).sofficeBinaryPaths ?? [];

Latest changes in the repository: e0eae70#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346R17

Node 10 doesn't support the nullish coalescing

Change node 10 to above 14.5.0+ suggest node version 15+ or lts and be careful when you migrate your node version some line of code might break.

Ref : https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing_operator Ref2 : https://node.green/#ES2021-features-Logical-Assignment-----basic-support

elwerene commented 2 years ago

Nice find! I'll fix it

elwerene commented 2 years ago

Does release 1.4.1 fix the issue for you?