search

elyalvarado / react-navigation-switch-transitioner

A react-navigation transitioner and switch navigator using it
MIT License
39 stars 7 forks source link

Update to react navigation 3.0 #8

Closed tpjnorton closed 5 years ago

tpjnorton commented 5 years ago

Since react navigation 3.0 you no longer need to call createNavigationContainer for custom navigators as this is wrapped at the top with a call to createAppContainer, see here for an explanation on this.

In fact. createNavigationContainer is now deprecated, and is throwing me dev-level warnings. Can we get this removed?

elyalvarado commented 5 years ago

@tn12787 yes of course, I'll probably be releasing a new version this weekend and include this change.

tpjnorton commented 5 years ago

Excellent, thanks very much!

On 25 Jan 2019, at 4:56 PM, Ely Alvarado notifications@github.com<mailto:notifications@github.com> wrote:

@tn12787https://github.com/tn12787 yes of course, I'll probably be releasing a new version this weekend and include this change.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/elyalvarado/react-navigation-switch-transitioner/issues/8#issuecomment-457619454, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGnsYFVm50YIKtCmZdZ5ltb6pyGXt_bOks5vGykZgaJpZM4aS_Za.

elyalvarado commented 5 years ago

This is the new default. The old behavior is still available for users of older versions of react-navigation by importing and using createContainedSwitchNavigator