search

elyase / geotext

Geotext extracts country and city mentions from text
MIT License
135 stars 47 forks source link

Case insensitive option #19

Open NicolleLouis opened 5 years ago

NicolleLouis commented 5 years ago

Hi,

First of all thanks for your work, it works well and it's really useful.

What do you think of an option to make a case insensitive search for city/country names. I'm trying to do it for my project, I can send you a PR if you want and I succeed.

albertc1 commented 5 years ago

I have a fork that includes case insensitive support and a few other features (support for states/provinces/etc., more languages parsed), but is probably a bit slower and might get you more false positives: https://github.com/tubular/geotext . If you try it and it works well for you, let me know and I can make a PR back to this main project

NicolleLouis commented 5 years ago

Hi, thanks for your answer.

I'm sorry albertc1, I made a custom solution before seeing your message, so I didn't try your fork. Thus I can't tell you if it worked well for me.

Good luck for everything