elyctech / web-gill

Gill is a WebGL-based rendering utility.
MIT License
0 stars 0 forks source link

Move Attribute and Uniform Enumeration Code from GillProgramService to GillWebglService #13

Closed dawsonc623 closed 7 years ago

dawsonc623 commented 7 years ago

To better encapsulate the operations directly related to WebGL, the two chunks of code related to enumerating attributes and uniforms from WebGLPrograms in lib/gill/program/service.class.ts starting at line 46 need to move to the GillWebglService type and implementation instead.

The attribute enumeration code needs moved to gillWebglService.getAttributes(webglProgram, webglRenderingContext).

The uniform enumeration code needs moved to gillWebglService.getUniforms(webglProgram, webglRenderingContext).