Support for Reports endpoint?

elyngved / ruby-mws

A Ruby library that wraps the Amazon MWS API.

MIT License

41 stars 64 forks source link

Support for Reports endpoint? #3

Closed radicaled closed 10 years ago

radicaled commented 12 years ago

They aren't very well tested (had trouble coming up with a test scheme), but I added some support for the "Reports" namespace / API.

I ended up doing a little refactoring inside of MWS::API::Base to support the response from Reports.GetReport (its returned as a raw CSV file, not XML).

Not sure if you're interested, but sending it out there anyway.

elyngved commented 12 years ago

Well I am certainly an ass as I've dropped the ball with this gem/pull request. I will check this out, thanks for your inclusion. Have you been using it with success?

elyngved commented 10 years ago

FYI I'm actually checking this out now. Trying to wrap my head around the code I wrote almost 2 years ago.

elyngved commented 10 years ago

I'm going to merge this and make a couple of edits. Namely, I feel like a binary response should just be sent as a block of text to the user, rather than having to call body on the response, since that more closely resembles the API. Thanks for your help!