elyra-ai / elyra

Elyra extends JupyterLab with an AI centric approach.
https://elyra.readthedocs.io/en/stable/
Apache License 2.0
1.86k stars 344 forks source link

Update classes in metadata-common into react components #2590

Open ajbozarth opened 2 years ago

ajbozarth commented 2 years ago

Describe the issue Currently MetadataEditorTags and FilterTools are defined as classes that extend React.Component. This is causing some race conditions with their state such as when handling tags. The bug would be easy to address using useEffect if we rewrote the classes as components as we did with many classes in pipeline-editor.

ajbozarth commented 2 years ago

note that this was found when addressing warnings in https://github.com/elyra-ai/elyra/pull/2570

karlaspuldaro commented 2 years ago

Relevant reference info https://github.com/elyra-ai/elyra/issues/1594#issuecomment-830323298