search

elyra-ai / elyra

Elyra extends JupyterLab with an AI centric approach.
https://elyra.readthedocs.io/en/stable/
Apache License 2.0
1.86k stars 343 forks source link

bump version of nbconvert #3214

Closed rkpattnaik780 closed 3 months ago

rkpattnaik780 commented 9 months ago

Bump version of nbconvert to fix the CVE issues introduced by mistune@2.0.3.

What changes were proposed in this pull request?

How was this pull request tested?

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.
lresende commented 6 months ago

@rkpattnaik780 could you please sign your commit?

rkpattnaik780 commented 6 months ago

@rkpattnaik780 could you please sign your commit?

Done. The checks are also passing now!

shalberd commented 6 months ago

@lresende this also fixes https://github.com/elyra-ai/elyra/issues/3228 Change looks good to me and I can confirm this works with Jupyterlab less than 4.

@rkpattnaik780 I see you are also involved at https://github.com/opendatahub-io/notebooks/blob/main/runtimes/minimal/ubi9-python-3.9/utils/requirements-elyra.txt

Can you also add the new nbconvert version to requirements-elyra, please? Thank you.