Closed cryptokage1996 closed 1 week ago
codecov[bot]
commented
2 weeks ago Attention: Patch coverage is 47.36842% with 60 lines in your changes missing coverage. Please review.
Project coverage is 43.08%. Comparing base (
3eca470) to head (b3e2e59). Report is 1 commits behind head on main.
cosmic-vagabond
commented
2 weeks ago @cryptokage1996 can you provide test results?
amityadav0
commented
2 weeks ago I see we are only setting stop loss value, shouldn't we add logic for stop loss trigger ? when this will trigger ?
cryptokage1996
commented
1 week ago I see we are only setting stop loss value, shouldn't we add logic for stop loss trigger ? when this will trigger ?
- When custody amount hits stop loss or is there any other variable ?
in the ticket it is not mentioned to close position when stop loss is hit, should i do it like we do for leveragelp @amityadav0
cosmic-vagabond
commented
1 week ago @cryptokage1996 @amityadav0 I agree without the ABCI logic for trigger the stop loss (closing of the position) it will be useful at all, is there any reason we are ommiting that part?
cryptokage1996
commented
1 week ago @cryptokage1996 @amityadav0 I agree without the ABCI logic for trigger the stop loss (closing of the position) it will be useful at all, is there any reason we are ommiting that part?
@cosmic-vagabond there is a new ticket to implement this
cosmic-vagabond
commented
1 week ago @cryptokage1996 the software upgrade test is failing due to a module migration error see here https://github.com/elys-network/elys/actions/runs/10771967355/job/29870663829?pr=759
cryptokage1996
commented
1 week ago @cryptokage1996 the software upgrade test is failing due to a module migration error see here https://github.com/elys-network/elys/actions/runs/10771967355/job/29870663829?pr=759
@cosmic-vagabond i dont know whats the issue here , code is fine i updated the registry and added migration from v6 to v7 it is still looking for v5 to v6 migration. i think this is issue bcoz the previous pr has migration in same module(perpetual) could be the reason , also iam not totally sure. @amityadav0 @avkr003 can your help here.is there anything iam missing? Thanks!
avkr003
commented
1 week ago @cryptokage1996 Multiple migrations are happening here, and your code is skipping one version.
err := cfg.RegisterMigration(types.ModuleName, 5, m.V6Migration) if err != nil { panic(err) }
Do not remove this. And add your code next to it:
err := cfg.RegisterMigration(types.ModuleName, 6, m.V7Migration) if err != nil { panic(err) }
Or,
You can add code in m.V7Migration to m.V6Migration at the end and remove .V7Migration and consensus version back to 6
Add message to update the stop loss of a given position.