elysiajs / elysia-apollo

Plugin for Elysia for using GraphQL Apollo
MIT License
4 stars 6 forks source link

File Incorrectly Being Picked Up by TS #4

Open SomeUserNameReally opened 1 year ago

SomeUserNameReally commented 1 year ago

When I run tsc this file is incorrectly picked up even after explicitly setting skipLibCheck and exclude options on tsconfig.json.

node_modules/@elysiajs/apollo/src/index.ts:65:41 - error TS2345: Argument of type 'string | (() => Promise<string>)' is not assignable to parameter of type 'ReadableStream<any> | BlobPart | BlobPart[] | FormData | URLSearchParams | null | undefined'.
  Type '() => Promise<string>' is not assignable to type 'ReadableStream<any> | BlobPart | BlobPart[] | FormData | URLSearchParams | null | undefined'.

65                     return new Response(landingPage, {
                                           ~~~~~~~~~~~

Found 1 error in node_modules/@elysiajs/apollo/src/index.ts:65

Even vscode picks it up!

Screenshot_20230918_012650

vincentvella commented 1 year ago

Hoping to get this fixed with https://github.com/elysiajs/elysia-apollo/pull/5