search

elysiajs / elysia-cors

Plugin for Elysia that for Cross Origin Requests (CORs)
MIT License
29 stars 8 forks source link

Upgrading from 1.0.2 to 1.0.4 causes CORS errors even if I `cors({ origin: true, credentials: true })` #53

Closed Blankeos closed 2 months ago

Blankeos commented 2 months ago

As the title says. Not sure what's going on...

Code: (no changes)

image

I also tried cors({ origin: true, credentials: true })

lyorb commented 2 months ago

Same problem, need to downgrade to 1.0.2 @SaltyAom

SaltyAom commented 2 months ago

Hi, can you please also attach an error message. You can find one in console tab, thanks

Blankeos commented 2 months ago

Hi @SaltyAom, no error logs relating to the CORs error unfortunately. Checked both in the browser and the backend.

Blankeos commented 2 months ago

I'm trying to make a repro right now. It's weird. It actually works on a minimal example, but for my project it doesn't. Let me try to investigate some more.

Might be related to https, TLS, or whatever (i'm running mine on HTTPs for browser Geo apis to work). No idea. I'll try experimenting.

SaltyAom commented 2 months ago

Should be fixed by a2a179a, published under 1.0.5

Blankeos commented 2 months ago

Works great. Thanks @SaltyAom !