elysiajs / elysia-html

A plugin for Elysia that add support for returning html
MIT License
24 stars 18 forks source link

example returns pre-formatted string, not HTML #29

Closed Lonitch closed 1 year ago

Lonitch commented 1 year ago

I'm trying out the following example of using the html plugin(0.7.3):

import { Elysia } from 'elysia'
import { html } from '@elysiajs/html' 

new Elysia()
    .use(html()) 
    .get('/', () => (
        <html lang="en">
            <head>
                <title>Hello World</title>
            </head>
            <body>
                <h1>Hello World</h1>
            </body>
        </html>
    ))
    .listen(3000)

The response header is content-type | text/plain;charset=utf-8, and the rendered HTML looks like the following:

image

The problem is solved when I switch back to 0.6.5.

cool3rain commented 1 year ago

Wrap your html code in backtick.

`

Hello World

Hello World

`
arthurfiorette commented 1 year ago

@Lonitch, I cannot reproduce your problem. What versions of bun, elysia and elysia html are you using?

Can you try this example? Does it works for you? Have you updated your bun version? Can you try reinstalling your packages?

Your example worked for me.

image

Lonitch commented 1 year ago

@arthurfiorette, I tried that one before switch back to 0.6.5, and it didn't work for me. my bun ver. is 1.0.0. Below is what I have in my package.json:

"dependencies": {
    "@editorjs/editorjs": "^2.28.0",
    "@editorjs/header": "^2.7.0",
    "@editorjs/image": "^2.8.1",
    "@editorjs/link": "^2.5.0",
    "@editorjs/list": "^1.8.0",
    "@elysiajs/html": "^0.6.5",
    "@elysiajs/static": "^0.6.0",
    "@kitajs/html": "^3.0.2",
    "@kitajs/ts-html-plugin": "^1.3.0",
    "@material-ui/core": "^4.12.4",
    "@t3-oss/env-core": "^0.7.0",
    "@types/markdown-it": "^13.0.1",
    "@types/react": "^18.2.28",
    "beth-stack": "^0.0.34",
    "elysia": "latest",
    "markdown-it": "^13.0.1",
    "react": "^18.2.0",
    "react-dom": "^18.2.0",
    "zod": "^3.22.4"
  },
  "devDependencies": {
    "bun-types": "latest",
    "typescript": "latest"
  },

The problem can also be solved by bun update.

arthurfiorette commented 1 year ago

So your problem was outdated bun?

Lonitch commented 1 year ago

No, bun update updates elysia. My bun ver. remains at 1.0.0.