search

elysiajs / elysia

Ergonomic Framework for Humans
https://elysiajs.com
MIT License
10.27k stars 219 forks source link

Semver not followed correctly #720

Closed cybercoder-naj closed 1 month ago

cybercoder-naj commented 3 months ago

What version of Elysia.JS is running?

1.1.0

What platform is your computer?

Linux 6.6.32-1-lts x86_64 unknown

What steps can reproduce the bug?

Upgrade an existing project from v1.0.x to v1.1.0.

What is the expected behavior?

Do not have any breaking changes.

What do you see instead?

Breaking changes with the onResponse function.

Additional information

According to SemVer, MINOR version when you add functionality in a backward compatible manner. I don't think it was necessary to rename the function and publish the breaking change as a minor version upgrade.

kravetsone commented 3 months ago

as an option, leave it deprecated)

cybercoder-naj commented 3 months ago

Agreed. decommissioned functions conventionally should be marked as deprecated until the next major release. I assume many libraries and production codes would break due to this change.