search

elyukai / optolith-client

Optolith Character Manager is a desktop application for The Dark Eye 5th Edition.
https://optolith.app
Other
161 stars 44 forks source link

Rugged Fighter doesn't affect character sheet pain levels #1602

Open l0b0 opened 1 year ago

l0b0 commented 1 year ago

Please confirm the following

Describe the bug

I believe "1/4 lost (Pain +1)" should not show up in the character sheet if I've got the Rugged Fighter advantage.

To Reproduce

  1. Create a character with Rugged Fighter advantage
  2. Go to the character sheet

Expected behavior

"1/2 lost (Pain +1)" should be the first pain level shown in the "Life Points" section

Screenshots

Screenshot from 2023-02-08 20-18-54

Operating System

Linux

Version

1.5.1

Additional context

No response

elyukai commented 1 year ago

Thank you so much for your big report(s)!

I did not think that far there, to be honest, it's just a static text I've taken over from other character sheets. But you're totally right.

Since this is not a critical bug, I have to delay its fix a bit, tho, since there are just way too many other issues around.

l0b0 commented 1 year ago

Would it be easy to omit the first line conditionally? Even if that means the rest of the lines have a bit of extra spacing above them it would be no big deal.

elyukai commented 1 year ago

I guess that should not be that hard. I used flexbox layout quite "aggressively" on the character sheet, so it should be able to adjust.

I’m currently thinking of splitting the texts to extract the (Pain +1) part, so that I could dynamically add it. Since I’m currently working on a new MAJOR version and I don't expect another V1 release before, I’ll try to include that change in the database rework, so that it can be taken into account for a V2 release.

ChrisHap commented 1 year ago

The rules for Rugged Fighter state, that you "Ignore the effects of the highest level of the condition Pain you possess" and that "Pain of Level IV still incapacitates you.".

Also the rule, that you fall unconcious if you are effected by 8 or more conditions, still applies. So the current implementation should be correct, even when you include Rugged Fighter.

Wujekklawy commented 1 year ago

you still suffer from Pain I with Rugged Fighter, you just don't get its effects. you still drop unconscious with Pain IV, which is 5hp or in your case 12hp and + Pain from a spell or ability