search

em-MRCZ / python-mrcz

Python module for compressed MRCZ-file format
Other
13 stars 4 forks source link

Proposed bugfix for writing new images/slices to existing MRC stacks #12

Closed rdrighetto closed 5 years ago

rdrighetto commented 5 years ago

ioMRC.readMRCheader() returns 'slices', however it also requires 'slices' as an argument. This leads to a bug when trying to write (e.g. append) images to an existing MRC file. A possible workaround is to pass 'slices=None' as an argument in such a case.

robbmcleod commented 5 years ago

Looks good to me. Ricardo, are you willing to add a test that does an append to test_mrcz.py?

rdrighetto commented 5 years ago

An appending test for a stack of 2D float32 images has been added.

robbmcleod commented 5 years ago

Ok thanks, merging. I will look into pushing out a new release this week.

rdrighetto commented 5 years ago

Hi Robb,

Would it be possible to push a new release to PyPI/conda-forge containing this bugfix? While it is already fixed here on the repo, I have mrcz as a dependency of another package I'm releasing on PyPI (https://github.com/C-CINA/focustools) and some of the features I'm implementing rely on this bugfix to work correctly.

Thanks!

robbmcleod commented 5 years ago

Sure but let's look into this pixelsize issue first.