fix: Allow quick navigation with (centaur-tabs-{backward,forward}--button)

ema2159 / centaur-tabs

Emacs plugin aiming to become an aesthetic, modern looking tabs plugin

GNU General Public License v3.0

743 stars 51 forks source link

fix: Allow quick navigation with (centaur-tabs-{backward,forward}--button) #233

Closed erikmd closed 4 months ago

erikmd commented 4 months ago

Summary

@jcs090218 I recently noticed that when clicking "too fast" on centaur-tabs-forward-button (resp. …-backward-…) several times, centaur-tabs only moves one tab at a time… which was quite distracting from a UX point of view.

This PR fixes this 🙂

Remarks

This patch is simpler than what I was expecting: Unbind (delete-other-windows) at [centaur-tabs-display-line double-mouse-1]
This is not a loss in functionality, given: Function (delete-other-windows) is already bound at [mode-line mouse-2]

jcs090218 commented 4 months ago

Can you elaborate on the situation? 🤔 I don't see the UX problem here. Thanks!

erikmd commented 4 months ago

Can you elaborate on the situation?

Sure! Let me know if you can reproduce the following issue:

(I'm using the latest centaur-tabs from MELPA using GNU Emacs 27.1)

Actual behavior:

When there are ≥ 3 visible tabs
Assuming the first tab is selected
When I click two times (quickly) on the forward button ⏵
(§) Then centaur-tabs only moves-right once (selecting the second tab) and display "No other windows to delete"

Expected behavior (OK after applying the PR):

(§) Then centaur-tabs moves-right twice (selecting the third tab)

erikmd commented 4 months ago

Hi @jcs090218 !

Was my explanation clear enough? or do you need more details

Kind regards.

jcs090218 commented 4 months ago

Sorry for the late reply!

I did not know there was a forward button since I switch tabs using the key more often. 🤔 I might have overlooked this customization.

erikmd commented 4 months ago

OK thanks @jcs090218 !

Indeed, I now realize that this feature is not "on" by default... so to give full context: