search

emabee / flexi_logger

A flexible logger for rust programs that can write to stderr, stdout, and/or to log files
Apache License 2.0
307 stars 50 forks source link

bufsize in std_writer::AsyncHandle #145

Closed hlhr202 closed 1 year ago

hlhr202 commented 1 year ago

Can i ask a stupid question. For std_writer::AsyncHandle::new function, why bufsize is marked as unused? I noticed that if we want to use AsyncWriter, we have to pass a bufsize where its default value is 8k https://github.com/emabee/flexi_logger/blob/master/src/primary_writer/std_writer.rs#L53C9-L53C17

emabee commented 1 year ago

Looks like a useless leftover from some refactoring, indeed. I should remove it as of the next version. Thanks for pointing it out!

emabee commented 1 year ago

I removed the redundant stuff