Highlighting doesn't catch mIRC color codes and is applied the wrong way around

wasamasa commented 9 years ago

I've observed two minor issues:

^C3wasamasa^C is not highlighted at all although it certainly reads like my nickname. Probably a case of boundaries that lead to a mismatch. Maybe this could be fixed by applying colors before doing nick highlighting instead of doing it afterwards?
^C3foo wasamasa bar^C is colored throughout with the highlighting face under it. This happens because lui-irc-propertize uses font-lock-prepend-text-property after the highlighting pass which puts it in front and therefore prioritizes it. Replacing it with font-lock-append-text-property fixes it and puts a highlight on the nick name while keeping the rest colored as expected.

jorgenschaefer commented 9 years ago

Good catch.

jorgenschaefer commented 8 years ago

Applying colors before nick highlighting would fix both issues at the same time, wouldn't it?

wasamasa commented 8 years ago

Sounds about right.

emacs-circe / circe