search

emacs-circe / circe

Circe, a Client for IRC in Emacs
GNU General Public License v3.0
395 stars 51 forks source link

Missing port in Bitlbee configuration breaks lui formatting #221

Closed jorgenschaefer closed 8 years ago

jorgenschaefer commented 9 years ago

When a network option is missing a port argument, Circe emits an unhelpful "unknown keyword argument port" – it should be smarter about detecting missing arguments.

Also, the Bitlbee network defaults need a default port. I think 6667 is pretty common.

Debugger entered--Lisp error: (error "Unknown keyword argument \"port\"")
  signal(error ("Unknown keyword argument \"port\""))
  error("Unknown keyword argument %S" "port")
  lui-format-lookup("port" (network "Bitlbee" host "localhost" port nil service nil))
  lui-format-single("port" (network "Bitlbee" host "localhost" port nil service nil))
  lui-format-internal("{host}:{port}" (network "Bitlbee" host "localhost" port nil service nil))
  lui-format("{host}:{port}" :network "Bitlbee" :host "localhost" :port nil :service nil)
  circe--server-generate-buffer((:nick "bananabas" :realname "bananabas" :user "bananabas" :nickserv-password "..." :host "localhost" :nickserv-mask "\\(bitlbee\\|root\\)!\\(bitlbee\\|root\\)@" :nickserv-identify-challenge "use the identify command to identify yourself" :nickserv-identify-command "PRIVMSG &bitlbee :identify {password}" :nickserv-identify-confirmation "Password accepted, settings and accounts loaded" :network "Bitlbee"))
  circe("Bitlbee")
  call-interactively(circe record nil)
  command-execute(circe record)
  execute-extended-command(nil "circe")
  call-interactively(execute-extended-command nil nil)
  command-execute(execute-extended-command)