emacs-circe / circe

Circe, a Client for IRC in Emacs
GNU General Public License v3.0
395 stars 51 forks source link

Customize type for tracking-ignored-buffers is incorrect #277

Open catern opened 8 years ago

catern commented 8 years ago

When using M-x customize to set tracking-ignored-buffers to a list containing a form of the kind (regexp faces ...) the value generated by customize which tracking-ignored-buffers is set to, is incorrect. Customize generates a value that has a list of faces rather than just the faces directly inside the parent list. That is, it's ("#" (face)) rather than ("#" face). Naturally this doesn't work with tracking.el.

jorgenschaefer commented 8 years ago

Nice catch, thank you for the report! :-)

wasamasa commented 8 years ago

In other words, we'd rather want a plist than a list of <...>.

jorgenschaefer commented 8 years ago

Currently, it's (list (choice regexp function) (repeat face)). Should be something like (cons (choice regexp function) (repeat face)) or something. No plist involved anywhere.

wasamasa commented 8 years ago

Oh right, it is the faces that repeat, not the pair of regexp/function and face.