circe-command-FOOL: regexp-quote the nick

emacs-circe / circe

Circe, a Client for IRC in Emacs

GNU General Public License v3.0

395 stars 51 forks source link

circe-command-FOOL: regexp-quote the nick #288

Open offby1 opened 8 years ago

offby1 commented 8 years ago

I hope the intent is obvious.

wasamasa commented 8 years ago

Not quite.

Why does this only apply to /fool, not /ignore as well?
How does one use regex if the need arises?
This is not bullet-proof in terms of matching. Assuming you /fool 123 and there is someone with a ~user@foobar123.host.org usermask, they will get filtered as well. This occurred to me a few times and needed to be solved with anchoring. See #28 for more thoughts on the topic.

jorgenschaefer commented 8 years ago

Thank you for the contribution! :-) wasamasa has some good questions there, though. I suspect a good solution would be to check if there's an exclamation mark in the string. If not, regexp-quote and add !.*@.* – though it's not clear to me if it should do submatches, word matches, or only full matches …