Closed glasserc closed 5 years ago
Thinking about this more, this isn't really correct, because not every Circe buffer has already had notifications for it. I thought you would get one for channel topics, but that probably isn't true, and query buffers don't necessarily have notifications either. I guess the right thing to do is to pass a list of every Circe buffer from a different layer.
Closing in favor of #346.
shorten-strings seems like it could be quadratic or worse, so having fewer things to shorten could make things more responsive.
This is a win for users who have lots and lots of buffers, but relatively few Circe buffers. It keeps track of all buffers that have ever been tracked forever, so it could potentially be a loss for people who keep very few buffers open, but cycle through lots of Circe buffers.
Refs #286 and #344.
I tested this both manually (
eval-buffer
and reconnecting to my znc bouncer) and using the automated tests on emacs 26.1. Of the versions inscripts/env
, none are "natively" available on NixOS unstable, which is what I'm running, so I didn't test those.