search

emacs-circe / circe

Circe, a Client for IRC in Emacs
GNU General Public License v3.0
391 stars 51 forks source link

Shorten only lui-mode buffer names #346

Closed glasserc closed 4 years ago

glasserc commented 5 years ago

shorten-strings seems like it could be quadratic or worse, so having fewer things to shorten could make things more responsive.

This seems like a violation of the software's layered design (lui knows about tracking, but tracking doesn't know about lui), but it's just a symbol name so maybe it's OK. Another alternative is to maybe define tracking-all-buffers as a hook in tracking and have lui provide its definition. This makes the interface between lui and tracking a bit more complicated, though.

Refs #286 and #344.

glasserc commented 5 years ago

This approach takes advantage of the fact that only lui adds buffers to tracking (at least so far), so look for any mode that's derived from lui-mode. This is more correct than #345, but maybe only marginally.

jorgenschaefer commented 5 years ago

tracking.el is a generic library and not specific to lui, so I do not think this is a good idea.

Also, the display of the buffers in the mode line should be unique globally, so the user knows which buffer is referred to. This functionality would be made useless by excluding some buffer names from the shortening function.

You can speed up tracking.el for lots of buffers by setting tracking-shorten-buffer-names-p to nil.

glasserc commented 4 years ago

I never got time to clean this up and I no longer use IRC any more, so I'll just close this.