search

emacs-circe / circe

Circe, a Client for IRC in Emacs
GNU General Public License v3.0
395 stars 51 forks source link

fix for GH-282: /GQUIT does nothing #358

Closed bad closed 4 years ago

bad commented 4 years ago

Apply same fix as in df9a1dc. While here fix that after /GQUIT circe would immediately try to reconnect.

wasamasa commented 4 years ago

If you only temporarily need to override circe-server-inhibit-auto-reconnect-p, use a let-binding around the affected code, otherwise the effect persists beyond that particular command.

bad commented 4 years ago

If you only temporarily need to override circe-server-inhibit-auto-reconnect-p, use a let-binding around the affected code, otherwise the effect persists beyond that particular command.

Or, better, wrap it in with-inhibited-reconnect, which $someone needs to create. In the end I did exactly what circe-command-QUIT does. I wanted to provide a minimal fix that is consistent with the style of the rest of the code. I didn't want to dump a large refactoring cum unrelated fix on you guys as my first contribution.