search

emacs-circe / circe

Circe, a Client for IRC in Emacs
GNU General Public License v3.0
390 stars 51 forks source link

[Question] how do I disable tracking from using the modeline? #378

Closed ag91 closed 3 years ago

ag91 commented 3 years ago

Hi, thanks for tracking.el it is nice to jump from buffer to buffer so easily. I am using https://github.com/yuya373/emacs-slack that uses your tracking.el library. I would like my modeline to stay clean of alerts, and I hoped that setting 

(setq tracking-max-mode-line-entries 0)

would do the trick. However that still leaves a single add an entry to the modeline, because the loop in tracking-status does not check for the 0 value. I ended up disabling it with a hack:

(defun tracking-status () nil)

What influenced your design to have always at least an entry in the modeline? Would it make sense to change it and would you like a PR?

wasamasa commented 3 years ago

Why not (tracking-mode -1)?

edit: Oh, you still want to use it for jumping through buffers, my bad.

wasamasa commented 3 years ago

I can't speak for the author's design decisions, but wouldn't be surprised if they never tested it for the case of zero. Irregardless of that I'd review a PR fixing this oversight.

ag91 commented 3 years ago

cool @wasamasa I will look into opening a PR then, worse case I will use it just as a local patch