search

emacs-circe / circe

Circe, a Client for IRC in Emacs
GNU General Public License v3.0
390 stars 51 forks source link

Dont use deprecated variables #380

Closed Thaodan closed 3 years ago

Thaodan commented 3 years ago

This replaces some deprecated symbols with their replacements. There's another one but that requires emacs 27.1:

circe-display-images.el:127:14: Warning: ‘url-get-url-at-point’ is an obsolete
    function (as of 27.1); use ‘thing-at-point-url-at-point’ instead.
wasamasa commented 3 years ago

The replacements look good so far, save for one line that seems to be a mistake. Regarding thing-at-point-url-at-point, that exists in Emacs 24.5 (which is a bugfix release following 24.4 which is the minimum version we use), so that should be fine to replace as well.

Thaodan commented 3 years ago

It was a mistake. I fixed that. I noted that url-get-url-at-point is deprecated only since emacs 27.1 still.

wasamasa commented 3 years ago

I've had to fix one missing paren. Will go over the Emacs 27-specific warnings now.