search

emacs-circe / circe

Circe, a Client for IRC in Emacs
GNU General Public License v3.0
390 stars 51 forks source link

Add `:verify-error t` when using new gnutls library #387

Closed AitorATuin closed 3 years ago

AitorATuin commented 3 years ago

Test should call make-network-process if tls was requested is expecting :verify-error t but currently its value nil.

According to the documentation the value of this keyword must be t to verify the peer certificate and the peer hostname.

The test was also failing.

wasamasa commented 3 years ago

https://github.com/jorgenschaefer/circe/pull/383

AitorATuin commented 3 years ago

Ok, well ... then I will at least fix the test :D To keep things traceable I will do it in another PR, so closing this one.

AitorATuin commented 3 years ago

https://github.com/jorgenschaefer/circe/pull/389 <- This PR fixes the test at least.