Closed snogge closed 4 months ago
Please correct the formatting to not use tabs. Other than that, this looks like a logical change, given the bump to Emacs 25.1.
Does the rule to not use tabs apply to all Emacs Lisp files?
Yes. To be fair, you'll be hard pressed to find any project besides Emacs itself still using them.
Done. I also added a .dir-locals.el file with this setting. And I see @Thaodan have also pushed a PR with this setting :)
Ironically, your patch did introduce more byte-compiler warnings due to the conditional definition of advice inside another function, so I've fixed that in a follow-up commit.
Please correct the formatting to not use tabs. Other than that, this looks like a logical change, given the bump to Emacs 25.1.