search

emacs-circe / circe

Circe, a Client for IRC in Emacs
GNU General Public License v3.0
390 stars 51 forks source link

Cleanup some obsolete defadvice #417

Closed snogge closed 4 months ago

wasamasa commented 5 months ago

Please correct the formatting to not use tabs. Other than that, this looks like a logical change, given the bump to Emacs 25.1.

Thaodan commented 5 months ago

Please correct the formatting to not use tabs. Other than that, this looks like a logical change, given the bump to Emacs 25.1.

Does the rule to not use tabs apply to all Emacs Lisp files?

wasamasa commented 5 months ago

Yes. To be fair, you'll be hard pressed to find any project besides Emacs itself still using them.

snogge commented 5 months ago

Done. I also added a .dir-locals.el file with this setting. And I see @Thaodan have also pushed a PR with this setting :)

wasamasa commented 4 months ago

Ironically, your patch did introduce more byte-compiler warnings due to the conditional definition of advice inside another function, so I've fixed that in a follow-up commit.