search

emacs-citar / citar

Emacs package to quickly find and act on bibliographic references, and edit org, markdown, and latex academic documents.
GNU General Public License v3.0
502 stars 54 forks source link

setf and buffer-substring #729

Closed bdarcus closed 1 year ago

bdarcus commented 1 year ago

With Emacs 29.1, use of setf with buffer-substring is effectively obsolete. Hopefully they reverse this, but am guessing they won't.

citar-org.el:407:12: Warning: ‘buffer-substring’ is an obsolete generalized
    variable.
citar-org.el:445:12: Warning: ‘buffer-substring’ is an obsolete generalized
    variable.

https://github.com/emacs-citar/citar/blob/3d84879b1793f327c68cabaddd6bedb35a030274/citar-org.el#L407-L408

See linked PR for an ugly fix.

See also:

https://github.com/minad/consult/issues/636