Fixes to citar--shorten-names

[pprevos]

When I use truncate as 1 or 2, it does not show "et al.", which should always show when namelength > truncate.

Changing tnamelength to namelength in the conditional fixes the issue.

Minor point, "et al" needs to be "et al.".

I used a citation with 7 authors for testing: https://doi.org/10.1038/s41545-022-00208-8

[pprevos]

Still needs some work. I get an issue with a paper with two authors and using truncate = 1

[bdarcus]

Still needs some work. I get an issue with a paper with two authors and using truncate = 1

Let me know when you want me to merge it to my branch?

[bdarcus]

Yeah, in retrospect, I have a hunch that first cond shouldn't be needed, and probably confuses things. We should try removing that.

[bdarcus]

Yeah, in retrospect, I have a hunch that first cond shouldn't be needed, and probably confuses things. We should try removing that.

Confirmed; I just pushed a commit that does this to my branch.

https://github.com/emacs-citar/citar/pull/732/commits/3eae3f2dbd3b42232b26ae945bae38c6c286301b

With that, I now get this:

ELISP> (citar--shorten-names "Doe, J and Smith, N and Jones, K and Lamb, H" 1)
"Doe et al."
ELISP> (citar--shorten-names "Doe, J and Smith, N" 1)
"Doe et al."
ELISP> (citar--shorten-names "Doe, J and Smith, N" 2 "&")
"Doe & Smith"

Should I just merge that then and close this?

Edit: yes, I'll probably do that, unless you uncover a problem with the logic, as among other things, my latest commits introduced a conflict with your branch ;-)

Aside: I'm still trying to figure out the formatting linting issue, hopefully before I merge.

[pprevos]

Thanks for all the hard work while I was asleep :)