emacs-citar / citar

Emacs package to quickly find and act on bibliographic references, and edit org, markdown, and latex academic documents.
GNU General Public License v3.0
479 stars 53 forks source link

Installing citar with guix: "Symbol's value as variable is void: citar-indicator-create" #814

Closed 9s-l-s9 closed 5 months ago

9s-l-s9 commented 6 months ago

Describe the bug I installed citar with guix. Even without any configuration and also with the basic config, I get the error: "Symbol's value as variable is void: citar-indicator-create" and my entire configuration is no longer loading. To be honest, I have no idea what could be the cause or how to debug this. Any ideas?

To Reproduce

  1. Install emacs-citar with guix.
  2. Start emacs

Emacs version: 30

Additional context Emacs --debug-init does not provide additional information.

bdarcus commented 6 months ago

I'm not really sure either, as I don't use guix.

But I assume you still need to configure citar for it to load correctly?

If yes, what is that configuration?

EDIT: citar-indicator-create is an autoloaded function.

bienjensu commented 5 months ago

I can, perhaps unsurprisingly, reproduce

Starting a pure environment with emacs-minimal and emacs-citar produces the error on startup.

It's worth noting that this doesn't happen with the last packed version for guix, 1.3.1. Currently trying to figure out what the issue is.

bienjensu commented 5 months ago

The problem seems to be that the indicator defstruct is autoloaded. However, cl-lib isn't necessarily present.

bdarcus commented 5 months ago

I thought cl-lib is included in emacs?

Is Nicholas still maintaining the package?

bienjensu commented 5 months ago

I thought cl-lib is included in emacs?

It is, although I've figured out that the version of emacs used in guix to build emacs packages by default has a problem resembling this related to having cl-lib macros in the autoloads.

I've adjusted the guix package argument, which fixes the issue.

Is Nicholas still maintaining the package?

Yes. I'm not too familiar with guix but I assume he'll be reviewing the patch :smiley:.

bdarcus commented 5 months ago

Great. So can we can close this?

bienjensu commented 5 months ago

Think so, yes!