search

emacs-citar / citar

Emacs package to quickly find and act on bibliographic references, and edit org, markdown, and latex academic documents.
GNU General Public License v3.0
501 stars 54 forks source link

Fix bug in `citar-citeproc-select-csl-style` #815

Closed benthamite closed 9 months ago

benthamite commented 9 months ago

Since list is a list of cons cells, to get the name of the csl style when list has one element caar needs to be used; car returns the cons cell itself.

benthamite commented 9 months ago

Separately (as I just noticed), I think the prompt on line 87 should be "Select CSL style: ", since the user is prompted to select a style, not a file.

bdarcus commented 9 months ago

Separately (as I just noticed), I think the prompt on line 87 should be "Select CSL style: ", since the user is prompted to select a style, not a file.

Could you please make that change while you're at it?

benthamite commented 9 months ago

Yep, done.

bdarcus commented 9 months ago

Thanks!

I did squash the commits so I could easily rewrite the commit message (though I realize there's a remaining mistake; the correction is to the prompt, rather than the docstring)

https://www.conventionalcommits.org