Small fix for highlighting of types in Tree-Sitter mode

emacs-csharp / csharp-mode

A major-mode for editing C# in emacs

GNU General Public License v3.0

154 stars 47 forks source link

Small fix for highlighting of types in Tree-Sitter mode #233

Closed joefbsjr closed 3 years ago

joefbsjr commented 3 years ago

Parameters with nested types like void Foo(Namespace.Type param) were not being highlighted correctly.

theothornhill commented 3 years ago

Thanks! Keep them coming :)

josteink commented 3 years ago

This PR broke the CI-build.

Ideally we shouldn't merge things crashing the build until the cause has been identified and fixed.

theothornhill commented 3 years ago

Yeah, it breaks for the same reason it for no apparent reason broke few weeks ago. I will try to sit down this evening, see why cask is failing suddenly :) (it gives us a note about seq - my guess is that tree-sitter uses a too new version for emacsversion < 26.3).