search

emacs-csharp / csharp-mode

A major-mode for editing C# in emacs
GNU General Public License v3.0
155 stars 47 forks source link

Implement the new multiline string functionality from cc mode #250

Closed theothornhill closed 3 years ago

theothornhill commented 3 years ago

Context: #207 #164

The current multiline string handling is flawed in that it gets slower and slower over proportional to the amount of strings in a file. Alan Mackenzie (CC Mode maintainer) has implemented new strategies for us to use (yay), so we should show him the curtesy ant implement it on our end, seeing I was the one to bother him with this...

Start of thread on sourceforge: https://sourceforge.net/p/cc-mode/mailman/message/37288835/

I'll be working slowly on this going forward, but since I'm on parental leave things move slowly these days :) If anyone is interested, this could be a low hanging fruit for nicer CC Mode support. @jcs090218, maybe you are interested?

josteink commented 3 years ago

but since I'm on parental leave things move slowly these days :)

Oh Noes! Not you too! 😅

Seriously though. Good luck and have fun!

Worst case scenario we will have to rely on tree-sitter instead. And that’s already what I do today, thanks to you 😉

theothornhill commented 3 years ago

but since I'm on parental leave things move slowly these days :)

Oh Noes! Not you too! 😅

You too? :D

Seriously though. Good luck and have fun!

Thanks! It is!

Worst case scenario we will have to rely on tree-sitter instead. And that’s already what I do today, thanks to you 😉

Yeah, It isn't really a huge problem. In addition, emacs may get its own tree sitter support soonish, so we may have to do that all over again soon. We get to really work on those grammars in the christmas holiday or something. Good fun!

josteink commented 3 years ago

You too? :D

Oh just a general comment. My parental leave started 6+ years ago, but somehow my open-source capacities never fully recovered 😅

No rush. We’ll get something working sooner or later, or maybe someone else will. That’s how open-source usually works.

In case you didn’t know, I “revived” this project 10 years back or so when it was (then) at least 2+ years dead already.

As long as the code is around and could be useful, usually someone finds a way to bring it forward. Whatever happens, things will probably work out. No stress 🙂

theothornhill commented 3 years ago

Absolutely! Emacs knows how not to die.

theothornhill commented 3 years ago

Fixed in 515b866