search

emacs-csharp / csharp-mode

A major-mode for editing C# in emacs
GNU General Public License v3.0
155 stars 47 forks source link

Maybe remove 27.1 related hacks #256

Closed theothornhill closed 1 year ago

theothornhill commented 2 years ago

Mostly just putting a note here.

I don't really think we need the hacks for 27.1 anymore. Admittedly, I haven't checked that the mode works without, but considering 27.2 is the current stable, it might be an idea to revisit whether the hacks should reside with us for much longer. Just redefining the function like we do is bound to cause some sort of issues, surely. But I don't really know :)

josteink commented 2 years ago

In the past I’ve used what Emacs versions are available I Debian Stable and various Ubuntu LTS releases as a measure of what is reasonable to support.

I guess now, with no other “big things” going on, might be a good time to revisit those versions.

josteink commented 2 years ago

If we think it’s reasonable to support the latest Ubuntu LTS (20.04, Focal), that means we should work with Emacs versions as low as 26.3:

https://packages.ubuntu.com/focal/emacs

theothornhill commented 2 years ago

Yes, this is reasonable! The reason I brought this up is that csharp mode works in 26.3 without the shim, and when debuntu decides to upgrade it is reasonable to expect they jump to 27.2 or even higher. Thus skipping 27.1. This is hypothetical, and I don't even know if it works in 27.2.

If I'm right removing the shim will support 26.3 just as well as before.

josteink commented 1 year ago

Old issue is old!