search

emacs-eaf / eaf-browser

A modern, customizable and extensible browser in Emacs
GNU General Public License v3.0
132 stars 26 forks source link

allow edit_url to search string #9

Closed taquangtrung closed 3 years ago

taquangtrung commented 3 years ago

Hi,

I created this PR which allows users to search for a string when editing URL (e).

Currently, when a user presses e to edit the URL and just type foo, then EAF browser will return a blank page. Using this PR, EAF can allow use to search for the string foo by using the default search engine.

This PR is accompanied by the PR https://github.com/emacs-eaf/emacs-application-framework/pull/827 in the main EAF framework.

Here, I split eaf-search-it into 2 functions eaf--create-search-url and eaf-search-it.

The function eaf--create-search-url will be called by the main EAF webengine to create the search string.

Could you advise if this feature is useful and can be merged?

Thanks!

manateelazycat commented 3 years ago

Looks https://github.com/emacs-eaf/emacs-application-framework/pull/827

taquangtrung commented 3 years ago

@manateelazycat : I updated the new code. Could you take a look?

manateelazycat commented 3 years ago

Thanks man!