search

emacs-eask / cli

CLI for building, running, testing, and managing your Emacs Lisp dependencies
https://emacs-eask.github.io/
GNU General Public License v3.0
138 stars 21 forks source link

package-lint seems to exit after first issue is found #134

Closed Fuco1 closed 1 year ago

Fuco1 commented 1 year ago

image

jcs090218 commented 1 year ago

Yeah, this is the design. If you want to lint through and see all errors you would have to add --allow-error flag.

Fuco1 commented 1 year ago

Wouldn't it be better to list all errors by default? That's how most lint tools operate.

Also, now it looks like eask itself crashed, with the util.js error being shown. That's what confused me.

jcs090218 commented 1 year ago

I guess there are two issues here?

  1. Change default to lint through all errors
  2. Exit process silently without printing node's stacktrace

I've opened a PR in #136 for (Pt. 2). I will work on (Pt. 1).

jcs090218 commented 1 year ago

Okay, everything are applied to the master branch! Can you test to see if it works? :)

Fuco1 commented 1 year ago

Yea it's much nicer now. The throw in the javascript was really annoying :)